Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Needed changes for a minimal Hooks working example #94

Merged
merged 7 commits into from
Sep 1, 2023
Merged

feat: Needed changes for a minimal Hooks working example #94

merged 7 commits into from
Sep 1, 2023

Conversation

lfbrehm
Copy link
Member

@lfbrehm lfbrehm commented Aug 30, 2023

These are very basic changes needed for a minimal working example for hooks.

Hooks

  • HookCallbackRequest now contain a secret, hook_id, object_id and pubkey_serial field.

Endpoints

  • EndpointHostType are changed to GRPC and S3 fields.

@lfbrehm lfbrehm requested a review from St4NNi August 31, 2023 12:44
St4NNi
St4NNi approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im fine with that!

@St4NNi St4NNi merged commit b2ecce3 into main Sep 1, 2023
4 checks passed
@St4NNi St4NNi deleted the feat/v2_hooks_alpha branch September 1, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@St4NNi St4NNi St4NNi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfbrehm @St4NNi